Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower ZT_MIN_PHYSMTU #2365

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Lower ZT_MIN_PHYSMTU #2365

merged 2 commits into from
Nov 12, 2024

Conversation

laduke
Copy link
Contributor

@laduke laduke commented Sep 13, 2024 •
edited
Loading

regarding #2361

This constant is only used in one place:

ZeroTierOne/node/Topology.hpp

Lines 419 to 425 in d9d58c8

if (pc.mtu <= 0) {
pc.mtu = ZT_DEFAULT_PHYSMTU;
} else if (pc.mtu < ZT_MIN_PHYSMTU) {
pc.mtu = ZT_MIN_PHYSMTU;
} else if (pc.mtu > ZT_MAX_PHYSMTU) {
pc.mtu = ZT_MAX_PHYSMTU;
}

This change can't affect anything unless the user configures this value in their local.conf

joseph-henry
joseph-henry approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@joseph-henry joseph-henry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't personally tested this PR but it does make some sense and I think since it is not going to affect people by default it is safe to merge.

@joseph-henry joseph-henry merged commit c092b63 into dev Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-henry joseph-henry joseph-henry approved these changes

@rcoder rcoder Awaiting requested review from rcoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laduke @joseph-henry